Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for data schema #2395

Closed
7 of 8 tasks
snide opened this issue Oct 2, 2019 · 3 comments · Fixed by #2398
Closed
7 of 8 tasks

Icons for data schema #2395

snide opened this issue Oct 2, 2019 · 3 comments · Fixed by #2398

Comments

@snide
Copy link
Contributor

snide commented Oct 2, 2019

We likely need a defined set of icons that match the schemas used across our apps. The immidate need is data grid, but this stuff indirectly goes into everything in Kibana from Lens to Discover.

I don't know whether we should use tokens or colored icons for this stuff. Here's a list of stuff I know we'd need. A lot of these have icons already

  • String (string)
  • Number (number)
  • Geo (globe)
  • Boolean (invert)
  • JSON/Object
  • Date (calendar)
  • Currency
  • URL (link?)

Beyond that, I could see us filling this in with ECS definitions. Likely the top level field types would be a good reference. https://www.elastic.co/guide/en/ecs/current/ecs-field-reference.html

@snide
Copy link
Contributor Author

snide commented Oct 2, 2019

@ryankeairns Here's a list. Some of these have duplication in the token list as well. My gut says this is geenrally what tokens are for, so maybe we should consider using them more widely?

My specific use case is in data grid where we use them to categorize field types.

image

@ryankeairns
Copy link
Contributor

It does seem as though tokens are the way forward. There are now several places where we're using these to denote field types, so let's make that cutover in anticipation of more to come.

I'll work on these initial two tokens and stay tuned for others from that ECS list to come into play.

There is a known universal currency icon (found this from several sources):
https://en.wikipedia.org/wiki/Currency_sign_(typography)

Screenshot 2019-10-03 08 43 30

For the JSON/object, I'm thinking of something like this, but more EUI-like:
https://thenounproject.com/search/?q=object%20code&i=2732958

Screenshot 2019-10-03 08 41 46

@ryankeairns
Copy link
Contributor

ryankeairns commented Oct 3, 2019

Correction: tokenObject already exists!

Screenshot 2019-10-03 10 13 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants