-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce EuiSwitch
a11y changes
#2385
Comments
Design question (@snide): elastic/kibana#43717 (comment) |
@thompsongl Lookign at the changes there, if switches are buttons, an |
Ok. I think we'll just need to update |
Functional test updates are the other sizeable effort. The original PR (linked above) has a lot of work we can cherry pick, but not every failure was resolved. |
What sort of situations are we getting into where we have switches without labels? Know of any examples? (Dave's right, we can technically support it with |
@myasonik elastic/kibana#43717 (comment) shows one case. It's likely there are others, but we'd have to find them. |
There are always going to be plenty. The label will often not be phsyicially bound to the component, but be described elsewhere. The very common example is anytime we need to show a column of switches against rich content. |
Refreshed my memory of just why this was so hard the first time around: Angular. We'll have to find a shim/manual update of Angular form dirty/touched checking for instances of EuiSwitch in Vis (still uses quite a lot of Angular). Per elastic/kibana#38269, we likely can't just wait for Angular to be removed. Just an update on the way forward. |
Would we ever ship 2 versions of a component? Like a |
I'd try to avoid doing this. It creates a matrix of maintainability on both sides that gets hairy. The last thing we want to do is make the situation more complicated to understand. |
#2193 was reverted because of difficulty upgrading Kibana. We want to reintroduce the changes and ensure time for upgrading Kibana before a FF
The text was updated successfully, but these errors were encountered: