Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should EuiPage be a main element? #2359

Closed
myasonik opened this issue Sep 23, 2019 · 1 comment
Closed

Should EuiPage be a main element? #2359

myasonik opened this issue Sep 23, 2019 · 1 comment

Comments

@myasonik
Copy link
Contributor

Does it make sense for EuiPage or EuiPageBody to be a <main> element?

Going through Kibana, most pages are missing a main element wich automated tools often yell about so we often hear about it when customers do their own audits.

If y'all want to keep EuiPage and friends free of semantics that's fair enough and we can push adding main elements to Kibana devs but it seemed like a good place.

@snide
Copy link
Contributor

snide commented Sep 23, 2019

I think it makes sense for Page body. We might want to have the element it uses as a prop, which defaults to main. I'm guessing a couple places use it multiple times in a layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants