Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Editability support #2350

Closed
sorenlouv opened this issue Sep 17, 2019 · 11 comments
Closed

[EuiComboBox] Editability support #2350

sorenlouv opened this issue Sep 17, 2019 · 11 comments

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Sep 17, 2019

I would love to have support for editing elements, and pasting multiple element in the combobox.

Use case
The User Management section of Kibana uses the EUI combobox, and I was experimenting with a bunch of roles. I wanted to add/remove multiple rows add a time using my clipboard, and I had to do this one-by-one because there is no copy/paste support. A couple of examples:

It is not possible to select multiple roles and copy/cut them:
cut doesn;t work

It is not possible to paste roles:
paste doesn;t work

Gmail handles email adresses similar to combobox. An email can both be copied, pasted and edited:
gmail example

@sorenlouv sorenlouv changed the title [Combobox] Copy/paste support [Combobox] Copy/paste/edit support Oct 29, 2019
@sorenlouv
Copy link
Member Author

sorenlouv commented Nov 19, 2019

Hey @cchaos

Just a bit of spam from my end :D

I've noticed this problem pop up a couple of times while using the product. In this case I needed to edit a single character in a long host but couldn't. My workaround so far has been to use the Dev Tools:
edit-missing2

I'd really like to use the combobox for a few things in APM but having it being editable is a must so we'll stick with good old input fields for now.

@cchaos
Copy link
Contributor

cchaos commented Nov 19, 2019

Sorry @sqren but it just hasn't become priority yet for us to support this mechanism. There's quite a bit of feature requests for this component but it's hard to be a one-stop-shop for all requirements. However, we're very receptive to PR's if you want to tackle it yourself!

@sorenlouv
Copy link
Member Author

Sure thing @cchaos. Thanks for responding 👍

@anishagg17
Copy link
Contributor

@sqren i will try to implement this

@sorenlouv
Copy link
Member Author

sorenlouv commented Mar 8, 2020

Looking forward to see what you come up with @anishagg17 👍

@cchaos cchaos changed the title [Combobox] Copy/paste/edit support [EuiComboBox] Copy/paste/edit support Mar 27, 2020
@cchaos cchaos changed the title [EuiComboBox] Copy/paste/edit support [EuiComboBox] Editability support Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cchaos
Copy link
Contributor

cchaos commented May 27, 2021

As a user I would like after writing a very long option, to edit it, without having to delete and create a new one.

I propose EuiComboBox to have a prop like: canEditSelected, then:

  1. EuiComboBoxPill could be clicked and open its content back on the EuiComboBoxInput
  2. pressing delete while in emptyEuiComboBoxInput will open the last pill content on the input field instead of deleting it.

this can be very helpful when creating custom options, or when the options are very similar.

Originally posted by @galangel in #4830

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@Blakko
Copy link

Blakko commented Nov 24, 2021

+1

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants