Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch between the prop types for EuiToast and TypeScript definitions #1957

Closed
claracruz opened this issue May 23, 2019 · 1 comment · Fixed by #1962
Closed

Mismatch between the prop types for EuiToast and TypeScript definitions #1957

claracruz opened this issue May 23, 2019 · 1 comment · Fixed by #1962

Comments

@claracruz
Copy link
Contributor

I am working on issue #25620 - Fix console errors and we've come across an issue where console errors are caused by Typescript definition for title prop being set to type string. The EUI toast JS file however defines propType for title as node.

Could we fix the mismatch between the prop types for EuiToast and TypeScript definitions please. @pugnascotia recommends an update to this to optionally allow ReactChild
@pugnascotia
Copy link
Contributor

I believe we've typically gone from string to ReactNode in these cases.

@thompsongl thompsongl mentioned this issue May 24, 2019
Merged
2 tasks
@claracruz claracruz mentioned this issue May 30, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EuiToast title prop should accept a node thompsongl/eui
2 participants
@claracruz @pugnascotia