Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script updates #1865

Closed
chandlerprall opened this issue Apr 20, 2019 · 5 comments
Closed

Release script updates #1865

chandlerprall opened this issue Apr 20, 2019 · 5 comments
Assignees
Labels

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Apr 20, 2019

release.js does not ensure the local master branch is up to date with upstream's HEAD and that the working space is clean, nor does it verify that all latest dependencies are installed/built locally. Both of these individually, and certainly together, mean a release could be missing changes (at best) or provide an incomplete or broken build.

@chandlerprall
Copy link
Contributor Author

Related: #1109

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@chandlerprall
Copy link
Contributor Author

This is definitely still a thing.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cee-chen
Copy link
Contributor

Closed by b269103 and eee88c7

@cee-chen cee-chen self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants