Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Shouldn't create pill when the window focus is changed #1801

Closed
cjcenizal opened this issue Apr 5, 2019 · 5 comments
Closed
Labels

Comments

@cjcenizal
Copy link
Contributor

To reproduce, create some input the combo box but don't hit enter. Give another OS-level window focus, e.g. by command-tabbing to another browser window. When you return to the page with the combo box, a new pill will have been created but ideally we should have preserved the user's input without creating a pill yet.

@cjcenizal cjcenizal added the bug label Apr 5, 2019
@theodesp
Copy link
Contributor

theodesp commented Apr 8, 2019

It also happens when you just use only use tabs to escape the current combo box

@chandlerprall
Copy link
Contributor

It also happens when you just use only use tabs to escape the current combo box

That interaction is by design, but is definitely the root cause of the reported bug.

@cjcenizal
Copy link
Contributor Author

@theodesp Here's some discussion around the original change that added this "create pill on blur behavior": #1353.

@chandlerprall I wonder if the Page Visibility API can help us here? Looks like it has broad browser support.

@chandlerprall
Copy link
Contributor

@cjcenizal page visibility api was my first thought too, though I believe it won't cover all use cases (e.g. tabbing between side-by-side windows).

@cchaos cchaos changed the title EuiComboBox shouldn't create pill when the window focus is changed [EuiComboBox] Shouldn't create pill when the window focus is changed Sep 20, 2020
@cee-chen
Copy link
Contributor

cee-chen commented Apr 3, 2023

Closing this as won't fix / not planned due to the age of the issue and the lack of other reports. I'd also be concerned at this point that removing the onBlur functionality would trip up existing users (since it's been around for so long).

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants