Pagination is zero indexed with no warning or notice

[iMerica]

Hi,

Off by one errors will occur to anyone who simply reads the docs as is. It would be helpful to explicitly tell users in the Pagination docs that page numbers start at zero. There is no standard and LOTS of APIs observe the first page as page 1.

Thanks,

Michael

https://elastic.github.io/eui/#/navigation/pagination

[theodesp]

I can take this. I was thinking of adding an info EuiCallOut with the following text:

Pagination page numbers start at zero (0). So if you set the activePage to 1, it will activate the second page.

Is that OK?

[snide]

I think just adding it to the props doc here will work well enough. I don't think this is something that needs to be a major warning. The props doc will do.

https://github.com/elastic/eui/blob/master/src/components/pagination/pagination.js#L192

Note how the comments in the propTypes here turn into documentation in the Props tab on the docs page.

[iMerica]

Anything that makes it show up on the Pagination docs page would be great 👍

[thompsongl]

Docs added in #1740