Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox doesn't behave well in single selection mode #1615

Closed
timroes opened this issue Feb 27, 2019 · 2 comments
Closed

EuiComboBox doesn't behave well in single selection mode #1615

timroes opened this issue Feb 27, 2019 · 2 comments
Assignees
Labels

Comments

@timroes
Copy link
Contributor

timroes commented Feb 27, 2019

When using the EuiComboBox with singleSelection={{ asPlainText: true }} it behaves not very well.

If you selected a value and then focus that field again and try to search for a new value, values are shown, but you cannot navigate anymore and replace that existing value. I am using here a GIF that @cchaos already posted in elastic/kibana#31585.

buggy behavior

Since we're needing that component a lot while moving the existing visualize editor over to React, we are currently blocked on this component to behave properly.

Also if you searched for a suggestion and hit Escape now, you're left with a broken state where your search is still shown in the combobox:

peek 2019-02-27 11-57

@cchaos
Copy link
Contributor

cchaos commented Feb 27, 2019

Thank you for making this issue. It bugs me so much too. I think we're somewhat at the mercy of an external plugin though react-input-autosize.

@chandlerprall does this look like something that could be fixed (quickly)? All of TSVB also just converted to using the single selection as text style so it's becoming a lot more popular.

@cchaos
Copy link
Contributor

cchaos commented Feb 27, 2019

The other half of that issue is that after having selected an item, you can keep typing and even leave it in a state where you've typed in something and it persists after leaving the combobox.

Whoops, posted in the issue not the PR... moving comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants