-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiRange show empty string in input when value is empty #1458
Comments
That type of functionality doesn't align with the HTML
What is a use case where the value should actually ever be null? |
The usecase is just better interactivity. Here is an example work flow
The input should be allowed to be blank for work flows like these. |
Ahh I see. I think we can handle that use case. It will probably have to do some validation and it might make the input temporarily invalid (show a red border) so it doesnt try to pass an empty string to the range until they've typed a valid number. Thanks for the clarification. |
that would be great. The same would happen if the range is outside of the min/max |
EuiRange value converts the
value
prop to a Number before passing the value toEuiFieldNumber
. This causes empty strings to get converted to zero and display zero even though the value is an empty string.EuiRange should allow empty string values and display and empty input when the value is an empty string.
The text was updated successfully, but these errors were encountered: