Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiDescribedFormGroup should not require children #1446

Closed
cjcenizal opened this issue Jan 17, 2019 · 3 comments
Closed

EuiDescribedFormGroup should not require children #1446

cjcenizal opened this issue Jan 17, 2019 · 3 comments
Labels

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jan 17, 2019

There are cases where we could want to use this component for layout purposes, where children needs to be empty. Here's an example, where the empty EuiDescribedFormGroup is used to present a "hide/show" button, which reveals additional content below it.

image

When open it looks like this:

image

@thompsongl
Copy link
Contributor

In the case above, is the button not passed to the row as children? What layout properties of the empty EuiFormRow are important to this case?

@cjcenizal cjcenizal changed the title EuiFormRow should not require children EuiDescribedFormGroup should not require children Feb 4, 2019
@cjcenizal
Copy link
Contributor Author

@thompsongl Ah, sorry, I meant EuiDescribedFormGroup, not EuiFormRow. I've updated the title and description. EuiDescribedFormGroup accepts description (rendered on the left side) and children (rendered on the right side). In the screenshot, the button is provided as part of the description.

@thompsongl
Copy link
Contributor

Ah, yeah, that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants