Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiComboBoxInput passes an invalid attribute #1168

Closed
chandlerprall opened this issue Sep 6, 2018 · 1 comment
Closed

EuiComboBoxInput passes an invalid attribute #1168

chandlerprall opened this issue Sep 6, 2018 · 1 comment
Labels
bug

Comments

@chandlerprall
Copy link
Contributor

EuiComboBoxInput passes the onClickAriaLabel attribute to EuiComboBoxPill but it isn't used by anything, and ends up getting passed down to a raw DOM node, throwing a React warning.

@cchaos this was part of #1139
@cchaos
Copy link
Contributor

cchaos commented Sep 11, 2018

It is used by the EuiBadge via ...rest but for the single selection it's also passed to a span. I'll fix

@cchaos cchaos mentioned this issue Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chandlerprall @cchaos