From cfa84f4ef25114b1edae62537dd006dfd9fc5cf9 Mon Sep 17 00:00:00 2001 From: Cee Chen <549407+cee-chen@users.noreply.github.com> Date: Mon, 30 Oct 2023 12:26:37 -0700 Subject: [PATCH] [EuiPopover] Increase visibility in dark mode (#7310) --- .stylelintrc.js | 1 + .../__snapshots__/breadcrumb.test.tsx.snap | 2 +- .../code_block_annotations.test.tsx.snap | 2 +- .../collapsed_nav_popover.test.tsx.snap | 2 +- .../__snapshots__/combo_box.test.tsx.snap | 2 +- .../column_selector.test.tsx.snap | 6 ++--- .../column_sorting.test.tsx.snap | 6 ++--- .../keyboard_shortcuts.test.tsx.snap | 6 ++--- .../range/__snapshots__/range.test.tsx.snap | 2 +- .../__snapshots__/super_select.test.tsx.snap | 8 +++---- .../__snapshots__/popover.rtl.test.tsx.snap | 2 +- .../__snapshots__/popover.test.tsx.snap | 22 +++++++++---------- src/components/popover/popover.tsx | 5 ++++- .../popover_arrow/_popover_arrow.styles.ts | 9 ++------ .../_popover_panel.test.tsx.snap | 16 +++++++------- .../popover_panel/_popover_panel.styles.ts | 12 +++++++++- .../popover/popover_panel/_popover_panel.tsx | 9 +++++++- .../table_pagination.test.tsx.snap | 2 +- .../__snapshots__/tour_step.test.tsx.snap | 12 +++++----- upcoming_changelogs/7310.md | 1 + 20 files changed, 72 insertions(+), 55 deletions(-) create mode 100644 upcoming_changelogs/7310.md diff --git a/.stylelintrc.js b/.stylelintrc.js index a9f4a8aa115..800fcafa1ff 100644 --- a/.stylelintrc.js +++ b/.stylelintrc.js @@ -8,6 +8,7 @@ module.exports = { // Enforce camelCase naming 'selector-class-pattern': camelCaseRegex, 'keyframes-name-pattern': camelCaseRegex, + 'custom-property-pattern': camelCaseRegex, // Opinionated rules 'declaration-no-important': true, diff --git a/src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap b/src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap index 262b3d4247c..dd549f47e9c 100644 --- a/src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap +++ b/src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap @@ -42,7 +42,7 @@ exports[`EuiBreadcrumbContent renders breadcrumbs with \`popoverContent\` with p aria-describedby="generated-id" aria-live="off" aria-modal="true" - class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom" + class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-light-isOpen-hasTransform-bottom" data-autofocus="true" data-popover-open="true" data-popover-panel="true" diff --git a/src/components/code/__snapshots__/code_block_annotations.test.tsx.snap b/src/components/code/__snapshots__/code_block_annotations.test.tsx.snap index a4b92f4e7c6..dda64206c41 100644 --- a/src/components/code/__snapshots__/code_block_annotations.test.tsx.snap +++ b/src/components/code/__snapshots__/code_block_annotations.test.tsx.snap @@ -39,7 +39,7 @@ exports[`EuiCodeBlockAnnotation renders 1`] = ` aria-label="aria-label" aria-live="off" aria-modal="true" - class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom" + class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-light-isOpen-hasTransform-bottom" data-autofocus="true" data-popover-open="true" data-popover-panel="true" diff --git a/src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/__snapshots__/collapsed_nav_popover.test.tsx.snap b/src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/__snapshots__/collapsed_nav_popover.test.tsx.snap index 40a7cb91633..adbd5df22ba 100644 --- a/src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/__snapshots__/collapsed_nav_popover.test.tsx.snap +++ b/src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/__snapshots__/collapsed_nav_popover.test.tsx.snap @@ -46,7 +46,7 @@ exports[`EuiCollapsedNavPopover renders the title and sub-items within the popov aria-label="aria-label" aria-live="off" aria-modal="true" - class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-hasTransform-right-euiCollapsedNavPopover__panel" + class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-light-isOpen-hasTransform-right-euiCollapsedNavPopover__panel" data-autofocus="true" data-popover-open="true" data-popover-panel="true" diff --git a/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap b/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap index a1e7f5f4028..fa570cd0649 100644 --- a/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap +++ b/src/components/combo_box/__snapshots__/combo_box.test.tsx.snap @@ -134,7 +134,7 @@ exports[`EuiComboBox renders the options list dropdown 1`] = `