diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a6414c6446f..3f47b10773d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,5 +12,5 @@ Summarize your PR. If it includes design elements include a screenshot or gif. - [ ] Added or updated **jest tests** - [ ] Checked for **breaking changes** and labeled appropriately - [ ] Checked for **accessibility** including keyboard-only and screenreader modes -- [ ] Checked for changes against **new themes** +- [ ] Check against **all themes** for compatability in both light and dark modes - [ ] A [changelog](https://github.com/elastic/eui/blob/master/CHANGELOG.md) entry exists and is marked appropriately diff --git a/src/themes/eui-amsterdam/global_styling/mixins/_panel.scss b/src/themes/eui-amsterdam/global_styling/mixins/_panel.scss index 778067e04b4..fd11002d11a 100644 --- a/src/themes/eui-amsterdam/global_styling/mixins/_panel.scss +++ b/src/themes/eui-amsterdam/global_styling/mixins/_panel.scss @@ -1,8 +1,3 @@ -/** - * Mixin for use in: - * - EuiCard - * - EuiPageContent -*/ @mixin euiPanel($selector) { @if variable-exists(selector) == false { @error 'A $selector must be provided to @mixin euiPanel().'; diff --git a/wiki/theme-development.md b/wiki/theme-development.md deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/wiki/theming.md b/wiki/theming.md index c31b2ee487a..424e9c7eb83 100644 --- a/wiki/theming.md +++ b/wiki/theming.md @@ -5,8 +5,8 @@ variables. Currently we maintain the following themes: * theme_light (the default EUI theme) * theme_dark (the same theme in dark) -* theme_amsterdam_light (the next itteration of the EUI light theme) -* theme_amsterdam_dark (the next itteration of the EUI dark theme) +* theme_amsterdam_light (the next iteration of the EUI light theme) +* theme_amsterdam_dark (the next iteration of the EUI dark theme) Each of these themes (outside of the default theme_light one) include variable, mixins, functions and other overwrites that adjust colors and sizing to fit the