From 4bf8c22e2db22796a3fc7a009ad7a9944544edb2 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 21 Mar 2024 15:16:45 -0700 Subject: [PATCH] Clean up/remove various responsive Sass files/modifiers + remove `.euiTableRowCell--isMobileHeader` - isn't used anywhere that I can tell :shrug: --- .../basic_table/__snapshots__/basic_table.test.tsx.snap | 4 ++-- .../basic_table/__snapshots__/in_memory_table.test.tsx.snap | 4 ++-- src/components/table/__snapshots__/table.test.tsx.snap | 2 +- src/components/table/_index.scss | 3 --- src/components/table/_responsive.scss | 0 src/components/table/_table.scss | 4 ---- src/components/table/mobile/_index.scss | 1 - src/components/table/mobile/_mobile.scss | 0 src/components/table/table.tsx | 4 +--- 9 files changed, 6 insertions(+), 16 deletions(-) delete mode 100644 src/components/table/_responsive.scss delete mode 100644 src/components/table/mobile/_index.scss delete mode 100644 src/components/table/mobile/_mobile.scss diff --git a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap index 68e47171ac87..e7a0821a876a 100644 --- a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap +++ b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap @@ -8,7 +8,7 @@ exports[`EuiBasicTable renders (bare-bones) 1`] = ` >
@@ -122,7 +122,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin >
diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap index 5a416252414e..124dc9fd0953 100644 --- a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap +++ b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap @@ -104,7 +104,7 @@ exports[`EuiInMemoryTable empty array 1`] = ` >
@@ -199,7 +199,7 @@ exports[`EuiInMemoryTable with items 1`] = ` >
diff --git a/src/components/table/__snapshots__/table.test.tsx.snap b/src/components/table/__snapshots__/table.test.tsx.snap index a156f3ca233c..c313785c71ac 100644 --- a/src/components/table/__snapshots__/table.test.tsx.snap +++ b/src/components/table/__snapshots__/table.test.tsx.snap @@ -3,7 +3,7 @@ exports[`renders EuiTable 1`] = `
diff --git a/src/components/table/_index.scss b/src/components/table/_index.scss index 6851e3432010..edb5a788d864 100644 --- a/src/components/table/_index.scss +++ b/src/components/table/_index.scss @@ -2,6 +2,3 @@ @import 'mixins'; @import 'table'; -@import 'responsive'; - -@import 'mobile/index'; diff --git a/src/components/table/_responsive.scss b/src/components/table/_responsive.scss deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/src/components/table/_table.scss b/src/components/table/_table.scss index 80d4b97687c3..c634c35a4d02 100644 --- a/src/components/table/_table.scss +++ b/src/components/table/_table.scss @@ -71,10 +71,6 @@ &--baseline { vertical-align: baseline; } - - &.euiTableRowCell--isMobileHeader { - display: none; // Hide if not mobile breakpoint - } } .euiTableRowCellCheckbox { diff --git a/src/components/table/mobile/_index.scss b/src/components/table/mobile/_index.scss deleted file mode 100644 index 15a75dfe483b..000000000000 --- a/src/components/table/mobile/_index.scss +++ /dev/null @@ -1 +0,0 @@ -@import 'mobile'; diff --git a/src/components/table/mobile/_mobile.scss b/src/components/table/mobile/_mobile.scss deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/src/components/table/table.tsx b/src/components/table/table.tsx index caa00fb74ffd..3afad947cfe4 100644 --- a/src/components/table/table.tsx +++ b/src/components/table/table.tsx @@ -36,9 +36,7 @@ export const EuiTable: FunctionComponent = ({ // TODO: Make the table responsive breakpoint customizable via prop const isResponsive = useIsWithinMaxBreakpoint('s') && responsive; - const classes = classNames('euiTable', className, { - 'euiTable--responsive': responsive, - }); + const classes = classNames('euiTable', className); const styles = useEuiMemoizedStyles(euiTableStyles); const cssStyles = [