From 39e6cb8d0531eaa1a82b993c26bf049bf7843aea Mon Sep 17 00:00:00 2001
From: Cee Chen <constance.chen@elastic.co>
Date: Wed, 5 Jun 2024 14:06:51 -0700
Subject: [PATCH] [EuiBasicTable][tech debt] Clean up now-unnecessary
 conditional mobile select all checkbox logic

- Since the mobile header no longer renders or non-mobile views, we don't need this conditional logic anymore wooo
---
 .../basic_table/__snapshots__/basic_table.test.tsx.snap      | 2 +-
 .../basic_table/__snapshots__/in_memory_table.test.tsx.snap  | 5 +++--
 packages/eui/src/components/basic_table/basic_table.tsx      | 5 ++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
index 9be600ab7b8..2334b0aee41 100644
--- a/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
+++ b/packages/eui/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
@@ -151,7 +151,7 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
                 aria-label="Select all rows"
                 class="euiCheckbox__input"
                 data-test-subj="checkboxSelectAll"
-                id="_selection_column-checkbox_generated-id_desktop"
+                id="_selection_column-checkbox_generated-id"
                 title="Select all rows"
                 type="checkbox"
               />
diff --git a/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
index 169da77c88a..c22cc2cbc85 100644
--- a/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
+++ b/packages/eui/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -10,7 +10,8 @@ exports[`EuiInMemoryTable behavior mobile header 1`] = `
     <input
       aria-label="Select all rows"
       class="euiCheckbox__input"
-      id="_selection_column-checkbox_generated-id_mobile"
+      data-test-subj="checkboxSelectAll"
+      id="_selection_column-checkbox_generated-id"
       title="Select all rows"
       type="checkbox"
     />
@@ -19,7 +20,7 @@ exports[`EuiInMemoryTable behavior mobile header 1`] = `
     />
     <label
       class="euiCheckbox__label"
-      for="_selection_column-checkbox_generated-id_mobile"
+      for="_selection_column-checkbox_generated-id"
     >
       Select all rows
     </label>
diff --git a/packages/eui/src/components/basic_table/basic_table.tsx b/packages/eui/src/components/basic_table/basic_table.tsx
index 97ffc82579e..0f09e5e16aa 100644
--- a/packages/eui/src/components/basic_table/basic_table.tsx
+++ b/packages/eui/src/components/basic_table/basic_table.tsx
@@ -711,13 +711,12 @@ export class EuiBasicTable<T extends object = any> extends Component<
       >
         {([selectAllRows, deselectRows]: string[]) => (
           <EuiCheckbox
-            id={this.selectAllIdGenerator(isMobile ? 'mobile' : 'desktop')}
+            id={this.selectAllIdGenerator()}
             checked={checked}
             indeterminate={indeterminate}
             disabled={disabled}
             onChange={onChange}
-            // Only add data-test-subj to one of the checkboxes
-            data-test-subj={isMobile ? undefined : 'checkboxSelectAll'}
+            data-test-subj="checkboxSelectAll"
             aria-label={checked || indeterminate ? deselectRows : selectAllRows}
             title={checked || indeterminate ? deselectRows : selectAllRows}
             label={isMobile ? selectAllRows : null}