From 0bba6388d45c00e468e39fceb75974881a6373af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Bevacqua?= Date: Thu, 22 Mar 2018 14:21:33 -0300 Subject: [PATCH] Fixed a bug with `EuiButtonEmpty` disabled state (#561) * cleaner design for hover empty button no bg * Updated changelog --- CHANGELOG.md | 1 + src/components/button/button_empty/_button_empty.scss | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4c7e5587681..2fe5d8096d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Fixed `EuiToolTip` bug which caused the tooltip to hide when moving the mouse around inside of the trigger element ([#557](https://github.com/elastic/eui/pull/557)) - Added a `buttonColor` prop to `EuiConfirmModal` ([#546](https://github.com/elastic/eui/pull/546)) - Added ‘baseline’ as option to `EuiFlexGroup`'s `alignItems` prop ([#546](https://github.com/elastic/eui/pull/546)) +- Fixed a bug where `EuiButtonEmpty` would offer a white background on hover when it was disabled, even when there was no such background transition on hover when the buttons are not disabled ([#561](https://github.com/elastic/eui/pull/561)) # [`0.0.33`](https://github.com/elastic/eui/tree/v0.0.33) diff --git a/src/components/button/button_empty/_button_empty.scss b/src/components/button/button_empty/_button_empty.scss index c1b0a00a6c0..6c680f1a882 100644 --- a/src/components/button/button_empty/_button_empty.scss +++ b/src/components/button/button_empty/_button_empty.scss @@ -45,8 +45,11 @@ fill: $euiButtonColorDisabled; } + &:focus { + background-color: transparent; + } + &:hover, &:focus { - background-color: $euiColorEmptyShade; text-decoration: none; } } @@ -75,8 +78,6 @@ $buttonTypes: ( } &:hover { - background-color: transparent; - @if ($name == 'disabled') { cursor: not-allowed; }