Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fixes a link in nori_part_of_speech token filter #97158

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

wonseop
Copy link
Contributor

@wonseop wonseop commented Jun 28, 2023

This PR fixes a wrong URL.
Apache Lucene has been using a different URL for the "Part of speech tags" page since v9.0.0.

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 28, 2023

💚 CLA has been signed

@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.10.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 28, 2023
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @wonseop !

I've left a suggestion that fixes a typo. And would you mind signing the contributor agreement, so we can accept your contribution?

@@ -305,7 +305,7 @@ Which responds with:

The `nori_part_of_speech` token filter removes tokens that match a set of
part-of-speech tags. The list of supported tags and their meanings can be found here:
{lucene-core-javadoc}/../analyzers-nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags]
{lucene-core-javadoc}/../aanalysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{lucene-core-javadoc}/../aanalysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags]
{lucene-core-javadoc}/../analysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@abdonpijpelink abdonpijpelink added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Jun 28, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jun 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@abdonpijpelink abdonpijpelink self-assigned this Jun 28, 2023
@wonseop
Copy link
Contributor Author

wonseop commented Jun 28, 2023

@abdonpijpelink
I've already signed the contributor agreement several times, but it's showing as not signed.

@wonseop wonseop changed the title [DOCS] Fixes a link in nori_part_of_speech token filter [DOC] Fixes a link in nori_part_of_speech token filter Jun 28, 2023
@abdonpijpelink
Copy link
Contributor

You are correct. It's @refarde who needs to sign the contributor agreement.

@wonseop
Copy link
Contributor Author

wonseop commented Jun 28, 2023

I'm so sorry. My sub account is @refarde. I have re-signed the contributor agreement as @refarde.

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again @wonseop !

@abdonpijpelink abdonpijpelink merged commit 9465e68 into elastic:main Jun 28, 2023
abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Jun 28, 2023
* [DOCS] Fixes a link in nori_part_of_speech token filter

* [DOCS] Fixes a typo in the link

---------

Co-authored-by: Wonseop Kim <[email protected]>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.9
8.8

abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Jun 28, 2023
* [DOCS] Fixes a link in nori_part_of_speech token filter

* [DOCS] Fixes a typo in the link

---------

Co-authored-by: Wonseop Kim <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jun 28, 2023
* [DOCS] Fixes a link in nori_part_of_speech token filter

* [DOCS] Fixes a typo in the link

---------

Co-authored-by: Wonseop Kim <[email protected]>
Co-authored-by: Wonseop Kim <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jun 28, 2023
* [DOCS] Fixes a link in nori_part_of_speech token filter

* [DOCS] Fixes a typo in the link

---------

Co-authored-by: Wonseop Kim <[email protected]>
Co-authored-by: Wonseop Kim <[email protected]>
@rjernst rjernst added v8.9.0 and removed v8.9.1 labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.8.3 v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants