-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fixes a link in nori_part_of_speech token filter #97158
Conversation
💚 CLA has been signed |
Documentation preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this @wonseop !
I've left a suggestion that fixes a typo. And would you mind signing the contributor agreement, so we can accept your contribution?
docs/plugins/analysis-nori.asciidoc
Outdated
@@ -305,7 +305,7 @@ Which responds with: | |||
|
|||
The `nori_part_of_speech` token filter removes tokens that match a set of | |||
part-of-speech tags. The list of supported tags and their meanings can be found here: | |||
{lucene-core-javadoc}/../analyzers-nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags] | |||
{lucene-core-javadoc}/../aanalysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{lucene-core-javadoc}/../aanalysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags] | |
{lucene-core-javadoc}/../analysis/nori/org/apache/lucene/analysis/ko/POS.Tag.html[Part of speech tags] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Pinging @elastic/es-docs (Team:Docs) |
@abdonpijpelink |
You are correct. It's @refarde who needs to sign the contributor agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again @wonseop !
* [DOCS] Fixes a link in nori_part_of_speech token filter * [DOCS] Fixes a typo in the link --------- Co-authored-by: Wonseop Kim <[email protected]>
* [DOCS] Fixes a link in nori_part_of_speech token filter * [DOCS] Fixes a typo in the link --------- Co-authored-by: Wonseop Kim <[email protected]>
* [DOCS] Fixes a link in nori_part_of_speech token filter * [DOCS] Fixes a typo in the link --------- Co-authored-by: Wonseop Kim <[email protected]> Co-authored-by: Wonseop Kim <[email protected]>
* [DOCS] Fixes a link in nori_part_of_speech token filter * [DOCS] Fixes a typo in the link --------- Co-authored-by: Wonseop Kim <[email protected]> Co-authored-by: Wonseop Kim <[email protected]>
This PR fixes a wrong URL.
Apache Lucene has been using a different URL for the "Part of speech tags" page since v9.0.0.