From 5f2c4e916ffdc8ac9636d187631f1e29a2a0e955 Mon Sep 17 00:00:00 2001 From: Tobias Frey <75436831+sag-tobias-frey@users.noreply.github.com> Date: Thu, 21 Oct 2021 11:13:51 +0200 Subject: [PATCH 1/3] Correct sentence in date.asciidoc --- docs/reference/mapping/types/date.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/mapping/types/date.asciidoc b/docs/reference/mapping/types/date.asciidoc index 06fb518c4e3e1..5c0c923250b1d 100644 --- a/docs/reference/mapping/types/date.asciidoc +++ b/docs/reference/mapping/types/date.asciidoc @@ -78,7 +78,7 @@ Dates // tag::decimal-warning[] will accept numbers with a decimal point like `{"date": 1618249875.123456}` but there are some cases ({es-issue}70085[#70085]) where we'll lose precision -on those dates so should avoid them. +on those dates so they should be avoided. // end::decimal-warning[] ==== From 6dde2fff78cf545008b2f53ed8bcedfc6f77bf5b Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Wed, 27 Oct 2021 10:29:42 -0400 Subject: [PATCH 2/3] move recommendation to front --- docs/reference/mapping/types/date.asciidoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/reference/mapping/types/date.asciidoc b/docs/reference/mapping/types/date.asciidoc index 5c0c923250b1d..89dc98ed5b1b3 100644 --- a/docs/reference/mapping/types/date.asciidoc +++ b/docs/reference/mapping/types/date.asciidoc @@ -74,11 +74,11 @@ GET my-index-000001/_search [WARNING] ==== +Avoid using a decimal point in date values. Dates // tag::decimal-warning[] -will accept numbers with a decimal point like `{"date": 1618249875.123456}` -but there are some cases ({es-issue}70085[#70085]) where we'll lose precision -on those dates so they should be avoided. +accept numbers with a decimal point, such as `{"date": 1618249875.123456}`, +but there are some cases ({es-issue}70085[#70085]) where they'll lose precision. // end::decimal-warning[] ==== From 8291d59e4ce320a9f87996b315fe6ef80a5de90a Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Wed, 27 Oct 2021 10:45:08 -0400 Subject: [PATCH 3/3] Revert "move recommendation to front" This reverts commit 6dde2fff78cf545008b2f53ed8bcedfc6f77bf5b. --- docs/reference/mapping/types/date.asciidoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/reference/mapping/types/date.asciidoc b/docs/reference/mapping/types/date.asciidoc index 89dc98ed5b1b3..5c0c923250b1d 100644 --- a/docs/reference/mapping/types/date.asciidoc +++ b/docs/reference/mapping/types/date.asciidoc @@ -74,11 +74,11 @@ GET my-index-000001/_search [WARNING] ==== -Avoid using a decimal point in date values. Dates // tag::decimal-warning[] -accept numbers with a decimal point, such as `{"date": 1618249875.123456}`, -but there are some cases ({es-issue}70085[#70085]) where they'll lose precision. +will accept numbers with a decimal point like `{"date": 1618249875.123456}` +but there are some cases ({es-issue}70085[#70085]) where we'll lose precision +on those dates so they should be avoided. // end::decimal-warning[] ====