Reject paginated search request exceeds rescore window #75556
Conversation
dnhatn
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
added
v7.15.0
>breaking
and removed
Team:Search
dnhatn
changed the title
| @@ -301,6 +302,24 @@ public ActionRequestValidationException validate() { | |||
| if (source.aggregations() != null) { | |||
| validationException = source.aggregations().validate(validationException); | |||
| } | |||
| if (source.rescores() != null) { | |||
| if (source.from() > 0) { | |||
There was a problem hiding this comment.
We should also check for the case where from is 0 but the window size is smaller than size alone ?
Changing the window size when paginating is also inconsistent so the window size should be thought with this limitation in mind. The initial window size must be greater or equals than the max allowed from+size to avoid pagination issues so I fear that this change will lead to more inconsistency (users that changed their window size on each request while paginating) ?
|
Hi @dnhatn, I've created a changelog YAML for you. Note that since this PR is labelled |
|
@dnhatn shall we close this? |
|
I am closing this PR as we will update the documentation instead. |
A search request with a positive
fromand the sum offromandsizethat exceeds the window size of rescorers can return inconsistent results. I think we should reject such a request.Closes #75363