[TEST] Add logging when LDAP server starts/stops #75322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logging to the in memory LDAP server in LdapTestCase that indicates when the server starts and stops and the addresses on which it is listening. Relates: elastic#75176
tvernum
added
>test
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Jul 14, 2021
Comment on lines
+113
to
+123
| String listenerConfig = listeners.stream() | ||
| .map( | ||
| l -> String.format( | ||
| Locale.ROOT, | ||
| "(%s @ %s:%d)", | ||
| l.getListenerName(), | ||
| NetworkAddress.format(resolveListenAddress(l.getListenAddress())), | ||
| ldapServer.getListenPort(l.getListenerName()) | ||
| ) | ||
| ) | ||
| .collect(Collectors.joining(",")); |
There was a problem hiding this comment.
Why not use InMemoryListenerConfig#toString? Is it because of the listenAddress?
There was a problem hiding this comment.
More due to the port - typically the config has port 0 and we want to know what port number was actually assigned.
tvernum
added
the
auto-merge-without-approval
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 14, 2021
This commit adds logging to the in memory LDAP server in LdapTestCase that indicates when the server starts and stops and the addresses on which it is listening. Relates: elastic#75176
💚 Backport successful
|
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
This commit adds logging to the in memory LDAP server in LdapTestCase that indicates when the server starts and stops and the addresses on which it is listening. Relates: elastic#75176
tvernum
pushed a commit
that referenced
this pull request
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logging to the in memory LDAP server in LdapTestCase
that indicates when the server starts and stops and the addresses on
which it is listening.
Relates: #75176