Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration check for legacy role settings #71197

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

jasontedor
Copy link
Member

This commit adds a migration check for the legacy role settings. This check checks for any usage of the legacy role settings, and informs the user of the correct value to use for the node.roles settings instead.

Relates #71143
Relates #54998

This commit adds a migration check for the legacy role settings. This
check checks for any usage of the legacy role settings, and informs the
user of the correct value to use for the node.roles settings instead.
@elasticmachine elasticmachine added Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team labels Apr 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jasontedor
Copy link
Member Author

With this change, the deprecation info API would give responses like:

{
  "cluster_settings" : [ ],
  "node_settings" : [
    {
      "level" : "critical",
      "message" : "setting [node.ingest] is deprecated in favor of setting [node.roles]",
      "url" : "",
      "details" : "the setting [node.ingest] is currently set to [false], instead set [node.roles] to [transform,data_frozen,master,remote_cluster_client,data,data_content,data_hot,data_warm,data_cold] (nodes impacted: [jason-mbp])"
    },
    {
      "level" : "critical",
      "message" : "setting [node.data] is deprecated in favor of setting [node.roles]",
      "url" : "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html#breaking_80_settings_changes",
      "details" : "the setting [node.data] is currently set to [true], instead set [node.roles] to [transform,data_frozen,master,remote_cluster_client,data,data_content,data_hot,data_warm,data_cold] (nodes impacted: [jason-mbp])"
    }
  ],
  "index_settings" : { }
}

@jasontedor
Copy link
Member Author

@elasticmachine update branch

@jasontedor jasontedor merged commit 07b99ef into elastic:7.x Apr 1, 2021
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read the code but the resulting response from the deprecation info API you provided LGTM

@jasontedor jasontedor deleted the legacy-role-settings-migration branch April 2, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >deprecation Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants