-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration check for legacy role settings #71197
Add migration check for legacy role settings #71197
Conversation
This commit adds a migration check for the legacy role settings. This check checks for any usage of the legacy role settings, and informs the user of the correct value to use for the node.roles settings instead.
Pinging @elastic/es-core-features (Team:Core/Features) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
With this change, the deprecation info API would give responses like: {
"cluster_settings" : [ ],
"node_settings" : [
{
"level" : "critical",
"message" : "setting [node.ingest] is deprecated in favor of setting [node.roles]",
"url" : "",
"details" : "the setting [node.ingest] is currently set to [false], instead set [node.roles] to [transform,data_frozen,master,remote_cluster_client,data,data_content,data_hot,data_warm,data_cold] (nodes impacted: [jason-mbp])"
},
{
"level" : "critical",
"message" : "setting [node.data] is deprecated in favor of setting [node.roles]",
"url" : "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html#breaking_80_settings_changes",
"details" : "the setting [node.data] is currently set to [true], instead set [node.roles] to [transform,data_frozen,master,remote_cluster_client,data,data_content,data_hot,data_warm,data_cold] (nodes impacted: [jason-mbp])"
}
],
"index_settings" : { }
} |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not read the code but the resulting response from the deprecation info API you provided LGTM
This commit adds a migration check for the legacy role settings. This check checks for any usage of the legacy role settings, and informs the user of the correct value to use for the node.roles settings instead.
Relates #71143
Relates #54998