Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning nested data in fields API #67432

Merged
merged 31 commits into from
Feb 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3269017
Group nested fields output for fields API
Jan 21, 2021
412bb74
Use mappingLookup to get nested object mappers
Jan 25, 2021
e757f95
iter, adding tests
Jan 25, 2021
5357649
checkstyle
Jan 25, 2021
b35c194
delegate nested mapping lookup
Jan 27, 2021
b201103
rename NestedValueFetcher
Jan 27, 2021
c342c64
only one fetchValues method
Jan 27, 2021
1d074b0
Remove unpacking of lists
Jan 27, 2021
f3b26b5
Merge branch 'master' into wip-63709
Jan 27, 2021
d569c50
Add dotted notation to yaml test
Jan 29, 2021
9fb1c2f
Fix field pattern problem and simplify resolution of nested fields
Feb 1, 2021
fab2286
Handle ignored_fields in ValueFetchers
Feb 1, 2021
2f9b645
Merge branch 'master' into wip-63709
Feb 1, 2021
c12dc54
iter
Feb 2, 2021
d23d3d2
don't pass null for ignored_fields in ValueFetcher calls
Feb 2, 2021
0f5df41
iter
Feb 2, 2021
99dae0d
fix yaml test for flattened fields with unmapped option
Feb 2, 2021
c197423
Merge branch 'master' into wip-63709
Feb 2, 2021
8a012a9
Merge branch 'master' into wip-63709
Feb 3, 2021
84c33e3
change license header for new class
Feb 3, 2021
4834760
pass on LeafReaderContext to internal FieldFetcher inside NestedValue…
Feb 3, 2021
9ba6920
muting running yaml test in runtime-fields/qa
Feb 3, 2021
8eaa6d3
Revert "muting running yaml test in runtime-fields/qa"
Feb 3, 2021
ea13fad
narrow scope of field resolving in nested field fetchers
Feb 3, 2021
0f999b1
Muting failing yaml test when run from x-pack/plugin/runtime-fields/qa
Feb 3, 2021
915b86e
iter minor changes
Feb 4, 2021
c8438e1
Fix handling of unmapped fields under nested fields
Feb 4, 2021
dc6760e
forbiddenapis
Feb 4, 2021
8f3d940
take out changed necessary for DocValueFetcher support
Feb 4, 2021
6833a84
Correct nested parent path lookup
Feb 4, 2021
3d6fb53
iter
Feb 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ static class TokenCountFieldType extends NumberFieldMapper.NumberFieldType {
@Override
public ValueFetcher valueFetcher(SearchExecutionContext context, String format) {
if (hasDocValues() == false) {
return lookup -> List.of();
return (lookup, ignoredFields) -> List.of();
}
return new DocValueFetcher(docValueFormat(format, null), context.getForField(this));
}
Expand Down
Loading