Small edits to Ranking Evaluation API docs #51116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small updates to grammar, syntax, and unclear wordings
cbuescher
added
:Search Relevance/Ranking
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Ranking) |
cbuescher
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Hi @liebeslied, thanks for opening the PR, it great to see how much this improves the readability of this particular section in the docs. Many thanks for that. I left a small request for change (if you agree with me), other than that I will run some requires CI tests and will merge as soon as you were able to reply to my suggestion below (... and I will work on my use of the possessive 's in English, as a non-native speaker, having written most of these docs its great to get this kind of feedback).
updating Ranking Evaluation API docs Co-Authored-By: Christoph Büscher <[email protected]>
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
cbuescher
pushed a commit
that referenced
this pull request
Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
cbuescher
pushed a commit
that referenced
this pull request
Jan 20, 2020
Small updates to grammar, syntax, and unclear wordings.
|
Thanks again @liebeslied, merged the PR to 7.5 and newer branches. |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Small updates to grammar, syntax, and unclear wordings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of clarity, fix some small grammar/syntax issues and change some wordings.