Add Logging to Mock Repo API Server #49409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we log exception in the handler, we may still miss exceptions hgiher up the execution chain. This adds logging of exceptions to all operations on the IO loop including connection establishment.
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
@tlrx my best guess is that we have some exception further up the stack (above the handler that has all the logging now) that's killing connections here (any exception on the IO loop causes a connection close right now). |
tlrx
pushed a commit
that referenced
this pull request
Nov 21, 2019
While we log exception in the handler, we may still miss exceptions hgiher up the execution chain. This adds logging of exceptions to all operations on the IO loop including connection establishment. Relates #49401
tlrx
pushed a commit
that referenced
this pull request
Nov 21, 2019
While we log exception in the handler, we may still miss exceptions hgiher up the execution chain. This adds logging of exceptions to all operations on the IO loop including connection establishment. Relates #49401
|
I merged this and backported it to 7.x and 7.5 so that we have this change on CI asap :) |
|
Thanks Tanguy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we log exception in the handler, we may still miss exceptions
hgiher up the execution chain. This adds logging of exceptions to all
operations on the IO loop including connection establishment.
Relates #49401