From 326462f82b5182a3ca450b4bf49563fcbdece2b9 Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Wed, 2 Oct 2019 17:23:47 +0200 Subject: [PATCH] Remove Incorrect Assertion from SnapshotsInProgress This relates to the effort towards #46250. We added tracking of the shard generation for successful snapshots to `8.0`. This assertion isn't correct though. While an `8.0` master won't create an entry with sucess state and a null shard generation it may still (on e.g. master failover) send a success entry created by a 7.x master with a `null` generation over the wire. Closes #47406 --- .../main/java/org/elasticsearch/cluster/SnapshotsInProgress.java | 1 - 1 file changed, 1 deletion(-) diff --git a/server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java b/server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java index 8a112950204c6..0afd79269796d 100644 --- a/server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java +++ b/server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java @@ -279,7 +279,6 @@ public ShardSnapshotStatus(StreamInput in) throws IOException { state = ShardState.fromValue(in.readByte()); if (in.getVersion().onOrAfter(SnapshotsService.SHARD_GEN_IN_REPO_DATA_VERSION)) { generation = in.readOptionalString(); - assert generation != null || state != ShardState.SUCCESS : "Received null generation for shard state [" + state + "]"; } else { generation = null; }