Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inner_hits retrieval when stored fields are disabled #34652

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Oct 19, 2018

This is the backport of #33018, a change was needed to handle indices with multiple types.
This change throws an error if stored fields are disabled on inner_hits for an index with multiple types

Closes #32941

This is the backport of elastic#33018, a change was needed to handle indices with multiple types.
This change throws an error if stored fields are disabled on `inner_hits` for an index with multiple types

Closes elastic#32941
@jimczi jimczi added >bug :Search/Search Search-related issues that do not fall into other categories v6.5.0 labels Oct 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi
Copy link
Contributor Author

jimczi commented Oct 19, 2018

\cc @astefan

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi merged commit a0a7032 into elastic:6.x Oct 24, 2018
@jimczi jimczi deleted the inner_hits_disable_stored_fields_6x branch October 24, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v6.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants