Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ObjectParser exception #31030

Merged
merged 7 commits into from
Jun 4, 2018
Merged

Change ObjectParser exception #31030

merged 7 commits into from
Jun 4, 2018

Conversation

cbuescher
Copy link
Member

ObjectParser should throw XContentParseExceptions, not IAE. A dedicated parsing
exception can includes the place where the error occurred.

Closes #30605

ObjectParser should throw XContentParseExceptions, not IAE. A dedicated parsing
exception can includes the place where the error occurred.

Closes elastic#30605
@cbuescher cbuescher added >enhancement :Core/Infra/Core Core issues without another label v7.0.0 v6.4.0 labels Jun 1, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Christoph Büscher added 2 commits June 1, 2018 17:00
@cbuescher
Copy link
Member Author

test this please

@cbuescher cbuescher merged commit 3f87c79 into elastic:master Jun 4, 2018
cbuescher pushed a commit that referenced this pull request Jun 4, 2018
ObjectParser should throw XContentParseExceptions, not IAE. A dedicated parsing
exception can includes the place where the error occurred.

Closes #30605
dnhatn added a commit that referenced this pull request Jun 4, 2018
* 6.x:
  Add TRACE, CONNECT, and PATCH http methods (#31079)
  Change ObjectParser exception (#31030)
  Make sure KeywordFieldMapper#clone preserves split_queries_on_whitespace. (#31049)
  [DOCS] Removes duplicated authentication pages
  [Rollup] Specialize validation exception for easier management (#30339)
  Enable customizing REST tests blacklist (#31074)
  [DOCS] Moves machine learning overview to stack-docs
  [ML] Add secondary sort to ML events (#31063)
  QA: Check rollup job creation safety (#31036)
  Adapt bwc versions after backporting #31045 to 6.3
  Remove usage of explicit type in docs (#29667)
  Move pipeline APIs to ingest namespace (#31027)
  Adapt bwc versions after backporting #31045 to 6.x
  Make Persistent Tasks implementations version and feature aware (#31045)
  Mute MatchPhrase*QueryBuilderTests
  [Docs] Fix typo in watcher conditions documentation (#30989)
  Remove wrong link in index phrases doc
  Reuse expiration date of trial licenses (#31033)
  Index phrases (#30450)
  [DOCS] Fixes accounting setting names (#30863)
  [DOCS] Rewords _field_names documentation (#31029)
dnhatn added a commit that referenced this pull request Jun 4, 2018
* master:
  Add get mappings support to high-level rest client (#30889)
  Fix index prefixes to work with span_multi (#31066)
  [DOCS] Removes redundant authorization pages
  [DOCS] Re-adds custom realm
  Change ObjectParser exception (#31030)
  Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (#31073)
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants