-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checksum docvalues files when load store metadata #30851
Conversation
In CorruptedFileIT, we corrupt a random segment file then check that the corrupting store is marked as corrupted. However, if a DocValues file is flipped, we will trip an assertion in a FixedBitSet when opening a SoftDeletesDirectoryReaderWrapper. This commit makes sure that we verify the DocValues files when loading the metadata from a store. Another option is to limit the set of corrupting files in the tests.
Pinging @elastic/es-distributed |
The stack trace:
|
I don't think we can force the checksum on the metadata retrieval this is just too costly. We should try to find a better way of doing this. |
I wonder why this is an assertion and not a hard IndexOutOfBounds exception. Also, it feels like we should pre check this higher up and throw an Index corrupted exception if things don't add up? |
@bleskes we try to make this not needed on the lucene end. stay tuned |
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo - LUCENE-8335: Enforce soft-deletes field up-front LUCENE-8341 is required to resolve elastic#30851.
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo which will resolve #30851 - LUCENE-8335: Enforce soft-deletes field up-front
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo which will resolve #30851 - LUCENE-8335: Enforce soft-deletes field up-front
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo which will resolve elastic#30851 - LUCENE-8335: Enforce soft-deletes field up-front
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo which will resolve #30851 - LUCENE-8335: Enforce soft-deletes field up-front
In CorruptedFileIT, we corrupt a random segment file then check that the corrupting store is marked as corrupted. However, if a DocValues file is flipped, we will trip an assertion in a FixedBitSet when opening a SoftDeletesDirectoryReaderWrapper. This commit makes sure that we verify the DocValues files when loading the metadata from a store.
Another option is to limit the set of corrupting files in the tests.