Suppress hdfsFixture if there are spaces in the path #30533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDFS sets its thread-name format based partly on a URL-encoded version of the path, but the URL-encoding of spaces as `%20` is interpreted as a field in the formatted string of type `2`, which is nonsensical. This change simply skips these tests in this case.
DaveCTurner
added
>test
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
May 11, 2018
| @@ -229,6 +229,11 @@ if (Os.isFamily(Os.FAMILY_WINDOWS)) { | |||
| fixtureSupported = true | |||
| } | |||
|
|
|||
| boolean legalPath = rootProject.rootDir.toString().contains(" ") == false | |||
There was a problem hiding this comment.
Maybe call it "allowedPath" or something like that. Legal sounds scary
There was a problem hiding this comment.
I've left it as legalPath to avoid divergence between this and #30302 and its backports, but I can update them all to allowedPath if you would prefer. Let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDFS sets its thread-name format based partly on a URL-encoded version of the
path, but the URL-encoding of spaces as
%20is interpreted as a field in theformatted string of type
2, which is nonsensical. This change simply skipsthese tests in this case.
Backport of #30302 to 5.6 - fails on local CI for obscure reasons, opening PR to verify it's just a local issue.