Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Attempt to issue synced-flush from allocated nodes #29680

Closed
wants to merge 4 commits into from

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 24, 2018

Today, SyncedFlushUtil attempts to issue synced-flush from any node in
the cluster. Rarely, the synced-flush was issued from a node which has
not received the latest routing table information. The (incomplete)
debug log shows that the synced-flush result does not include any active
shard.

This change makes sure that we only issue synced-flush nodes which are
assigned shards from the requesting index.

Closes #29392

Today, SyncedFlushUtil attempts to issue synced-flush from any node in
the cluster. Rarely, the synced-flush was issued from a node which has
not received the latest routing table information. The (incomplete)
debug log shows that the synced-flush result does not include any active
shard.

This change makes sure that we only issue synced-flush nodes which are
assigned shards from the requesting index.

Closes elastic#29392
@dnhatn
Copy link
Member Author

dnhatn commented Apr 24, 2018

@bleskes Can you please take a look? I am unable to make a review request. Thank you!

@dnhatn dnhatn requested a review from bleskes April 24, 2018 22:12
@dnhatn dnhatn added the :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. label Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests >non-issue labels Apr 24, 2018
@dnhatn
Copy link
Member Author

dnhatn commented May 1, 2018

Talked to Boaz on another channel, we feel this might not be an actual cause. I added debug log for these tests in 038fe11.

Closing - thanks @bleskes for reviewing this.

@dnhatn dnhatn closed this May 1, 2018
@dnhatn dnhatn deleted the test/execute-sync-flush-nodes branch May 1, 2018 14:22
@bleskes bleskes added v6.3.0 and removed v6.3.1 labels May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >non-issue >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants