-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Longer RCS suite timeout due to slow keystore #117157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>test
Issues or PRs that are addressing/adding tests
:Security/Security
Security issues without another label
Team:Security
Meta label for security team
auto-backport
Automatically create backport pull requests when merged
v8.15.0
v8.16.0
v9.0.0
v8.17.0
labels
Nov 20, 2024
slobodanadamovic
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's also unmute muted tests on 8.x branch.
n1v0lg
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Nov 20, 2024
Pinging @elastic/es-security (Team:Security) |
@elasticmachine update branch |
This was referenced Nov 20, 2024
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883 (cherry picked from commit 312f831)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883 (cherry picked from commit 312f831)
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883 (cherry picked from commit 312f831)
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 21, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations. We should follow this up with performance improvements around keystore setup in tests. Closes: elastic#116883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Security/Security
Security issues without another label
Team:Security
Meta label for security team
>test
Issues or PRs that are addressing/adding tests
v8.15.0
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.
We should follow this up with performance improvements around keystore setup in tests.
Closes: #116883