Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer RCS suite timeout due to slow keystore #117157

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Nov 20, 2024

Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: #116883

@n1v0lg n1v0lg added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.15.0 v8.16.0 v9.0.0 v8.17.0 labels Nov 20, 2024
@n1v0lg n1v0lg self-assigned this Nov 20, 2024
Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's also unmute muted tests on 8.x branch.

@n1v0lg n1v0lg marked this pull request as ready for review November 20, 2024 14:27
@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 20, 2024

@elasticmachine update branch

@n1v0lg n1v0lg merged commit 312f831 into elastic:main Nov 20, 2024
20 of 21 checks passed
@n1v0lg n1v0lg deleted the longer-rcs1-suite-timeout branch November 20, 2024 16:43
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
(cherry picked from commit 312f831)
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 20, 2024

💚 All backports created successfully

Status Branch Result
8.x
8.16
8.15

Questions ?

Please refer to the Backport tool documentation

n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
(cherry picked from commit 312f831)
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15
8.16
8.x

n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
(cherry picked from commit 312f831)
elasticsearchmachine pushed a commit that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: #116883
(cherry picked from commit 312f831)
elasticsearchmachine pushed a commit that referenced this pull request Nov 20, 2024
* Longer RCS suite timeout due to slow keystore (#117157)

Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: #116883

* Unmute
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Nov 20, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
elasticsearchmachine pushed a commit that referenced this pull request Nov 21, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: #116883
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Rather than muting the suite and losing signal, bump the suite timeout to account for very slow keystore operations.

We should follow this up with performance improvements around keystore setup in tests.

Closes: elastic#116883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.15.0 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RemoteClusterSecurityReloadCredentialsRestIT testFirstTimeSetupWithElasticsearchSettings failing
4 participants