Remove some dead code from SearchPhase and friends #116645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The separate `onFailure` is unnecessary, just fail the phase like we do elsewhere. Also make utility method static.
original-brownbear
added
>non-issue
:Search Foundations/Search
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
javanna
approved these changes
Dec 4, 2024
original-brownbear
added
the
auto-backport
original-brownbear
added
the
auto-merge-without-approval
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 4, 2024
The separate `onFailure` is unnecessary, just fail the phase like we do elsewhere. Also make utility method static.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separate
onFailureis unnecessary, just fail the phase like we do elsewhere. Also make utility method static.