Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search coordinator uses event.ingested in cluster state to do rewrites #111523

Merged

Conversation

quux00
Copy link
Contributor

@quux00 quux00 commented Aug 1, 2024

Min/max range for the event.ingested timestamp field (part of Elastic Common Schema) was added to
IndexMetadata in cluster state for searchable snapshots in #106252.

This commit modifies the search coordinator to rewrite searches to MatchNone if the query searches
a range of event.ingested that, from the min/max range in cluster state, is known to not overlap. This
is the same behavior we currently have for the @timestamp field.

Min/max range for the event.ingested timestamp field (part of Elastic Common
Schema) was added to IndexMetadata in cluster state for searchable snapshots
in elastic#106252.

This commit modifies the search coordinator to rewrite searches to MatchNone
if the query searches a range of event.ingested that, from the min/max range
in cluster state, is known to not overlap. This is the same behavior we currently
have for the @timestamp field.
@quux00 quux00 added >enhancement Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.16.0 :Search Foundations/Search Catch all for Search Foundations labels Aug 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @quux00, I've created a changelog YAML for you.

@quux00 quux00 requested a review from javanna August 18, 2024 14:26
@quux00 quux00 merged commit 0d37197 into elastic:main Aug 26, 2024
15 checks passed
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
elastic#111523)

* Search coordinator uses event.ingested in cluster state to do rewrites

Min/max range for the event.ingested timestamp field (part of Elastic Common
Schema) was added to IndexMetadata in cluster state for searchable snapshots
in elastic#106252.

This commit modifies the search coordinator to rewrite searches to MatchNone
if the query searches a range of event.ingested that, from the min/max range
in cluster state, is known to not overlap. This is the same behavior we currently
have for the @timestamp field.
@elasticsearchmachine
Copy link
Collaborator

@quux00 according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is labelled release highlight but the changelog has no highlight section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement release highlight :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants