Fix ClusterSearchShardsResponseTests#testSerialization #100557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search (Team:Search) |
ldematte
reviewed
Oct 10, 2023
| Version nodeVersion = VersionUtils.randomVersion(random()); | ||
| DiscoveryNodeUtils.Builder node = DiscoveryNodeUtils.builder(shardRouting.currentNodeId()) | ||
| .address(new TransportAddress(TransportAddress.META_ADDRESS, randomInt(0xFFFF))) | ||
| .version(nodeVersion, IndexVersion.getMinimumCompatibleIndexVersion(nodeVersion.id), IndexVersion.fromId(nodeVersion.id)); |
There was a problem hiding this comment.
For nodeVersion > 8.10, I fear that fromId could give you back a IndexVersion you are expecting.
I would use IndexVersionUtils.randomVersion() if you want to introduce additional randomness, or IndexVersionUtils.current() if you want something that covers all.
Nit: I would consider using IndexVersion.ZERO or IndexVersion.MINIMUM_COMPATIBLE for min.
CC @thecoop as he is the expert in this area.
There was a problem hiding this comment.
Yeah, you can't go from version -> indexversion. Using IndexVersion.MINIMUM_COMPATIBLE and IndexVersion.current() is the best bet here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serialization random versioning.
closes: #100289