Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AggregatorTestCase#searchAndReduce(...) more inline with what happens in Search API #98672

Closed
martijnvg opened this issue Aug 21, 2023 · 2 comments
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@martijnvg
Copy link
Member

Currently AggregatorTestCase has its own search logic that unit tests all the aggregations. However this isn't in line with logic in the Search API. Especially with after this recent change: #98204.

Ideally search logic uses in unit tests should be similar with how aggregations get executed in production. However this currently not the case and this causes the unit test coverage to miss certain bugs/issues.

We should investigate whether we can bring the AggregatorTestCase#searchAndReduce(...) more in line with what happens in the Search API. Maybe QueryPhase/AggregatioPhase should be changed to allow unit tests or maybe something else.

@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations labels Aug 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@iverase
Copy link
Contributor

iverase commented Sep 27, 2023

After #98715 , this can be closed as now AggregatorTestCase is inline with the search API.

@iverase iverase closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

3 participants