Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestChunkedXContentListener always responds with a 200 Status.OK #98389

Open
romseygeek opened this issue Aug 11, 2023 · 3 comments
Open

RestChunkedXContentListener always responds with a 200 Status.OK #98389

romseygeek opened this issue Aug 11, 2023 · 3 comments
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities priority:high A label for assessing bug priority to be used by ES engineers :Search Foundations/Search Catch all for Search Foundations Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.9.0

Comments

@romseygeek
Copy link
Contributor

Elasticsearch Version

8.9

Installed Plugins

No response

Java Version

bundled

OS Version

n/a

Problem Description

#94736 reworked search responses to use chunked responses, reducing the probability that a very large response might cause out-of-memory problems on co-ordinating nodes. However, the REST layer code that handles these chunked responses always returns a status code of 200, and searches can return other codes here if some or all shards are missing. We should add a status-handling version of this code, similar to RestStatusToXContentListener.

I uncovered this while working on converting AsyncSearchResponse to use chunked responses, which tripped an explicit test that checks for the status code returned over the REST layer. It seems we don't have similar tests for plain searches.

Steps to Reproduce

n/a

Logs (if relevant)

No response
@romseygeek romseygeek added >bug :Search/Search Search-related issues that do not fall into other categories :Core/Infra/REST API REST infrastructure and utilities v8.9.0 labels Aug 11, 2023
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team labels Aug 11, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@benwtrent benwtrent added the priority:high A label for assessing bug priority to be used by ES engineers label Jul 9, 2024
@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities priority:high A label for assessing bug priority to be used by ES engineers :Search Foundations/Search Catch all for Search Foundations Team:Core/Infra Meta label for core/infra team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.9.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javanna @romseygeek @benwtrent @elasticsearchmachine