-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back sparse_vector
mapping
#98104
Comments
Pinging @elastic/es-search (Team:Search) |
Unassigning this for now, as first priority once someone is free. |
This is the work that I'll start doing for this task:
Anything I'm missing? Some questions I would like your opinion on:
|
Please, just copy paste. Especially since rankfeaturesfieldmapper is in a module and sparsevector will not be.
We should't do that until the ELSER queries are updated and such. Don't do anything related to ELSER in the
IMO, no, we should not. They do the same thing for now but they might diverge and
Maybe in a separate PR. This is not as important as getting the field mapping back and switching ELSER.
Yes, we should |
Thanks for the feedback, @benwtrent ! I created this draft PR. Can you please take a look to ensure it's in line with your thoughts? |
Completed per #98996 |
Description
We have
rank_features
and its useful as is. However, when comparing with new retrieval techniques, the namerank_features
isn't expected.Users expect
sparse_vector
as a partner withdense_vector
.So, we should bring back
sparse_vector
. It may initially be a simple copy ofrank_features
.See history: #48368, #48781
The text was updated successfully, but these errors were encountered: