-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when using deprecated syntax #8963
Comments
Closed in favour of #11033 |
Reopening. We should always log deprecations (based on the deprecation logging settings). For warn, we should add a "warnings" section to the response, which lists all warnings. Strict throws an exception. The The parse fields behaviour should be changed to collect deprecations, instead of throwing an exception, so that all warnings can be collected. |
I know we send a header when some usersIs this done or just partly done? |
I think this can be closed now - we have enough tooling around deprecations |
Did we do any of these? I hope we did and I missed them :) |
We did this one, but only in non-strict mode. It just collects deprecated stuff and sends |
Currently, users have to read the release notes for every version to check what syntax/functionality has been deprecated. We should make it easier, by warning or even throwing an exception.
This can be controlled by the
deprecations
setting which accepts:warn
- logs and returns a warning in the request body when deprecated syntax/functionality/end points are usederror
- throw an exception when deprecated syntax/functionality/end points are usedignore
- silently ignore deprecationsThe default setting should be
warn
, to inform users during development of problems with their code. The user can set it toerror
to be sure that they are catching all problems, and they can set it toignore
in production so that known usage of deprecated functionality does not obscure real problems.The text was updated successfully, but these errors were encountered: