Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Remove wire serialization version checks for <7.17 #81503

Closed
hendrikmuhs opened this issue Dec 8, 2021 · 2 comments
Closed

[Transform] Remove wire serialization version checks for <7.17 #81503

hendrikmuhs opened this issue Dec 8, 2021 · 2 comments
Labels
:ml/Transform Transform >refactoring Team:ML Meta label for the ML team

Comments

@hendrikmuhs
Copy link

a lot of version classes still do wire serialization version checks. For actions BWC layers have been removed in #79927, but the configuration classes (TransformConfig) still have version checks in writeTo and the corresponding readers.

Best if this get addressed after 7.17 has been branched, so the latest addition #81491 can be removed, too.
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Dec 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek self-assigned this Dec 8, 2021
@hendrikmuhs
Copy link
Author

fixed by #91150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:ml/Transform Transform >refactoring Team:ML Meta label for the ML team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hendrikmuhs @elasticmachine @przemekwitek