Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing automatic search threadpool queue resizing #72779

Open
dakrone opened this issue May 5, 2021 · 3 comments
Open

Consider removing automatic search threadpool queue resizing #72779

dakrone opened this issue May 5, 2021 · 3 comments
Labels
:Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@dakrone
Copy link
Member

dakrone commented May 5, 2021

We added the ability for the search queue to be automatically resized based on Little's Law in #23884, however, that work requires a desired response time to be set by a user, and thus was not very useful without knowing a great deal about your workload and topology.

With adaptive replica selection being implemented and available for quite a while now as a reasonable alternative, we should consider removing the automatic queue resizing feature in ES.

@dakrone dakrone added >enhancement :Core/Infra/Core Core issues without another label labels May 5, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@dakrone dakrone changed the title Consider removing automatic queue resizing Consider removing automatic search threadpool queue resizing May 5, 2021
@dakrone dakrone added discuss and removed discuss labels May 6, 2021
@geekpete
Copy link
Member

geekpete commented Nov 9, 2022

This one is resolved by #52280?
Was deprecated in 7.x and removed in 8.x?

I also wondered if we ever tested benchmarks with both queue resizing and ARS turned on for any combined benefit?
https://writequit.org/org/es/presentations/adaptive-replica-selection-presentation.html

@dakrone
Copy link
Member Author

dakrone commented Nov 9, 2022

It was half-resolved, because we had to keep the special threadpool around internally to gather metrics required for Adaptive Replica Selection. So I would say that it was removed from a user's point of view, but not from a "tech debt" point of view.

As far as testing, I never did any testing with both enabled at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants