Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of the total_shards_per_node to the beginning of the ILM shrink step #72725

Closed
joegallo opened this issue May 4, 2021 · 4 comments
Assignees
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team

Comments

@joegallo
Copy link
Contributor

joegallo commented May 4, 2021

If the total_shards_per_node per node setting will prevent the shards of the index from all being relocated to a single node, then we should fail the shrink action without having set-single-node-allocation since it won't work anyway.

For example, if the index has 5 shards, but total_shards_per_node is set to 3 for this index, then we won't be able to actually move all the shards onto one node -- failing this early with a validation / pre-flight error would be better than attempting to set-single-node-allocation and then waiting forever for it to do something that it isn't going to do.

@joegallo joegallo added >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management needs:triage Requires assignment of a team area label labels May 4, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@joegallo
Copy link
Contributor Author

joegallo commented May 4, 2021

Related to #56062 because this could be one of the potential failure cases mentioned there.

@DaveCTurner
Copy link
Contributor

Also relates #44070.

@gwbrown gwbrown removed the needs:triage Requires assignment of a team area label label May 12, 2021
@gmarouli
Copy link
Contributor

Issue #76732 allows the shrink action to unset the index's index.routing.allocation.total_shards_per_node
setting, meaning that there will be no limit and the shrink process can continue. This validation is not necessary anymore.

cc @masseyke , @dakrone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team
Projects
None yet
Development

No branches or pull requests

5 participants