Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change of default of max_number_of_snapshots in v8 #68886

Closed
DaveCTurner opened this issue Feb 11, 2021 · 4 comments
Closed

Breaking change of default of max_number_of_snapshots in v8 #68886

DaveCTurner opened this issue Feb 11, 2021 · 4 comments
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.5.0

Comments

@DaveCTurner
Copy link
Contributor

In #64461 we introduced the ability to set a limit on the number of snapshots in a repo, but in the backport to 7.11 we set the limit to Integer.MAX_VALUE to avoid introducing a breaking change in this minor release. However, the limit reduces to 500 in 8.0 which now represents a future breaking change. Today this change gets no mention in the 8.0 breaking changes docs, nor a deprecation warning in 7.x to help users prepare for it.

For changes to parameter defaults we'd usually require users to set the parameter explicitly to avoid the deprecation warning. I'm not sure that works in this case, if we say "you must set max_number_of_snapshots" then users will explicitly set it too high to work around their current snapshot hygiene problems, rather than dealing with the root cause.

@DaveCTurner DaveCTurner added >bug blocker :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 labels Feb 11, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@repantis
Copy link

Removing the blocker label, per @DaveCTurner's suggestion, since 8.0.0 shipped without this fix, but still tracking this as a bug.

@Leaf-Lin
Copy link
Contributor

Leaf-Lin commented Jun 2, 2022

As of #74350, @original-brownbear has improved the max_numbef_of_snapshots in v8. There was a doc PR on the removal of the soft limit.

What's still needed to be done on this issue?

@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@original-brownbear
Copy link
Member

I don't think there's anything left to be done here, we went for no limit now and improved scalability instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.5.0
Projects
None yet
Development

No branches or pull requests

8 participants