Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Painless annotation validation #68323

Open
nik9000 opened this issue Feb 1, 2021 · 1 comment
Open

Painless annotation validation #68323

nik9000 opened this issue Feb 1, 2021 · 1 comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@nik9000
Copy link
Member

nik9000 commented Feb 1, 2021

As we've started adding more and more "annotations" to painless's method whitelist we're bumping into the need for annotations to validate things. Mostly its that some annotations only fit on certain kinds of methods. The @compile_time_only annotation that we added in #68088 can only go on from_class imported method and instant bindings and can't go on regular methods or augmentations, for example. But there are likely lots of examples I haven't thought of. For our own sanity, we need to make it easier to annotations to validate themselves.

@nik9000 nik9000 added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Feb 1, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

2 participants