Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a parameters table in each aggregation doc page #66205

Open
2 of 67 tasks
mindrones opened this issue Dec 11, 2020 · 7 comments
Open
2 of 67 tasks

Provide a parameters table in each aggregation doc page #66205

mindrones opened this issue Dec 11, 2020 · 7 comments
Labels
:Analytics/Aggregations Aggregations >docs General docs changes >enhancement Meta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@mindrones
Copy link

mindrones commented Dec 11, 2020

It would be very useful if all aggregation doc pages had a list of parameters like the one in https://www.elastic.co/guide/en/elasticsearch/reference/7.9/search-aggregations-bucket-rare-terms-aggregation.html#_syntax. [1]

Right now for most of the aggregations every time we need to inspect the parameters shape we have to look for that info by scrolling a lot ot text. Also sometimes there's no mention of default values or if a parameter is required or not, so having a table like that clearly states it would be really awesome.

As we're doing this anyway, if there is a repository where to provide a PR (elastic/docs maybe?) we'd be glad to help!

[1]

Screenshot 2020-12-11 at 15 02 54

Aggregations to update

Bucket aggregations

  • Adjacency matrix [DOCS] Reformat adjacency matrix agg reference #70034
  • Auto-interval date histogram
  • Children
  • Composite
  • Date histogram
  • Date range
  • Diversified sampler
  • Filter
  • Filters
  • Geo-distance
  • Geohash grid
  • Geotile grid
  • Global
  • Histogram
  • IP range
  • Missing
  • Nested
  • Parent
  • Range
  • Rare terms
  • Reverse nested
  • Sampler
  • Significant terms
  • Significant text
  • Terms
  • Variable width histogram

Metrics aggregations

  • Avg
  • Boxplot
  • Cardinality
  • Extended stats
  • Geo-bounds
  • Geo-centroid
  • Geo-Line
  • Matrix stats
  • Max
  • Median absolute deviation
  • Min
  • Percentile ranks
  • Percentiles
  • Rate
  • Scripted metric
  • Stats
  • String stats
  • Sum
  • T-test
  • Top hits
  • Top metrics
  • Value count
  • Weighted avg

Pipeline aggregations

  • Avg bucket [DOCS] Reformat avg bucket agg reference #69751
  • Bucket script
  • Bucket selector
  • Bucket sort
  • Cumulative cardinality
  • Cumulative sum
  • Derivative
  • Extended stats bucket
  • Inference bucket
  • Max bucket
  • Min bucket
  • Moving function
  • Moving percentiles
  • Normalize
  • Percentiles bucket
  • Serial differencing
  • Stats bucket
  • Sum bucket
@mindrones mindrones added >enhancement needs:triage Requires assignment of a team area label labels Dec 11, 2020
@tvernum tvernum added :Analytics/Aggregations Aggregations >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Dec 14, 2020
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@mindrones
Copy link
Author

I forgot, it would be useful to have fields sorted alphabetically.

@jrodewig jrodewig assigned jrodewig and unassigned jrodewig Dec 16, 2020
@jrodewig jrodewig added the Meta label Jan 12, 2021
@jrodewig
Copy link
Contributor

jrodewig commented Jan 12, 2021

Thanks for raising this @mindrones. I'll progressively work on adding these parameter sections to the agg docs. I've updated your issue description with a list of aggregations to update.

As we're doing this anyway, if there is a repository where to provide a PR (elastic/docs maybe?) we'd be glad to help!

Thanks for your interest in contributing! You can find the source .asciidoc files for our docs in the elastic/elasticsearch repo: https://github.com/elastic/elasticsearch/tree/master/docs/reference/aggregations

Please feel free to submit a PR!

@jrodewig jrodewig self-assigned this Jan 12, 2021
@mindrones
Copy link
Author

@jrodewig thanks so much for the pointers. More or less we have collected this info for ourselves so it shouldn't take much to transfer that to asciidoc 🍀. I'll open a PR as soon as possible.

@lockewritesdocs
Copy link
Contributor

The creator of this issue is no longer with Elastic and the issue has been stale for over a year. I'm removing the Team:Docs label -- if someone wants to own this from the @elastic/es-analytics-geo team, please take ownership! Otherwise, we can close this issue.

@mitar
Copy link
Contributor

mitar commented Sep 16, 2022

+1 on adding such list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >docs General docs changes >enhancement Meta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

6 participants