-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQL: Error responses do not include caused_by
fields
#63855
Comments
Pinging @elastic/es-ql (:Query Languages/EQL) |
EQL exceptions are Elasticsearch exceptions (both semantically and in terms of hierarchy) however that doesn't mean they should contain a |
@costin thanks for the response, that's great information! It sounds like the logic in kibana could be more correct, then. I wasn't able to find any current documentation on the structure of these error responses, however I tracked down what looks to be the original PR for standardizing errors, which then lead to this subsequent PR in kibana. Just a few quick clarifications, then, to assist in creating the kibana issue:
|
@rylnd I don't think the response message format is documented, or at least I couldn't find this info. Maybe a question better asked to the wider Elasticsearch team. I see a tangential mentioning in the "Common options" docs page: https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html#common-options-error-options. Regarding the structure of the error message, an ElasticsearchException (which we use as base class for our eql exceptions) can output a detailed error message or a trimmed down one, depending on Looking at the code in ElasticsearchException:
|
Thanks for the help here! I've opened elastic/kibana#81857 to address this on the kibana side 👍 |
Elasticsearch version (
bin/elasticsearch --version
): 7.10BC2When error responses are returned from EQL searches, they lack the
error.caused_by.type
anderror.caused_by.reason
fields that appear to be standard across elasticsearch error responses.In practice, this means that the default response error presentation in kibana does not provide useful EQL error information to the user, despite it being present elsewhere in the response.
Example EQL error response:
Example elasticsearch error response (taken from elastic/kibana#70352):
The text was updated successfully, but these errors were encountered: