Side effects in HDFS File System Testing Fixtures Gradle tasks configuration block are fixed

[breskeby]

The task configuration block of these test fixtures in

elasticsearch/plugins/repository-hdfs/build.gradle

Lines 99 to 137 in abed62e

	// Create HDFS File System Testing Fixtures for HA/Secure combinations
	for (String fixtureName : ['hdfsFixture', 'haHdfsFixture', 'secureHdfsFixture', 'secureHaHdfsFixture']) {
	project.tasks.create(fixtureName, org.elasticsearch.gradle.test.AntFixture) {
	dependsOn project.configurations.hdfsFixture, project(':test:fixtures:krb5kdc-fixture').tasks.postProcessFixture
	executable = "${BuildParams.runtimeJavaHome}/bin/java"
	env 'CLASSPATH', "${-> project.configurations.hdfsFixture.asPath}"
	maxWaitInSeconds 60
	onlyIf { BuildParams.inFipsJvm == false }
	waitCondition = { fixture, ant ->
	// the hdfs.MiniHDFS fixture writes the ports file when
	// it's ready, so we can just wait for the file to exist
	return fixture.portsFile.exists()
	}
	final List<String> miniHDFSArgs = []
	// If it's a secure fixture, then depend on Kerberos Fixture and principals + add the krb5conf to the JVM options
	if (fixtureName.equals('secureHdfsFixture') || fixtureName.equals('secureHaHdfsFixture')) {
	miniHDFSArgs.add("-Djava.security.krb5.conf=${krb5conf}")
	}
	// If it's an HA fixture, set a nameservice to use in the JVM options
	if (fixtureName.equals('haHdfsFixture') || fixtureName.equals('secureHaHdfsFixture')) {
	miniHDFSArgs.add("-Dha-nameservice=ha-hdfs")
	}
	// Common options
	miniHDFSArgs.add('hdfs.MiniHDFS')
	miniHDFSArgs.add(baseDir)
	// If it's a secure fixture, then set the principal name and keytab locations to use for auth.
	if (fixtureName.equals('secureHdfsFixture') || fixtureName.equals('secureHaHdfsFixture')) {
	miniHDFSArgs.add("hdfs/hdfs.build.elastic.co@${realm}")
	miniHDFSArgs.add(
	project(':test:fixtures:krb5kdc-fixture').ext.krb5Keytabs("hdfs", "hdfs_hdfs.build.elastic.co.keytab")
	)
	}
	args miniHDFSArgs.toArray()
	}
	}

has side effects that require it currently to be always executed. This means we cannot benefit from the gradle task avoidance api as this task always needs to be created to execute this configuration.

This is an aftermath of #56627

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/Build)

[breskeby]

Fixed by #65011

[breskeby]

false alarm. still there

[breskeby]

fixed