Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Validate params for next page requests #52207

Closed
matriv opened this issue Feb 11, 2020 · 3 comments
Closed

SQL: Validate params for next page requests #52207

matriv opened this issue Feb 11, 2020 · 3 comments
Labels
:Analytics/SQL SQL querying >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@matriv
Copy link
Contributor

matriv commented Feb 11, 2020

Currently, the next page request can have all the params as the initial sql query request.
Most of them (apart from columnar and page_timeout are ignored internally, but it will be safer
to add a validation to prevent of accidental use of those params that will only make sense in the
initial request.

Based on #51258, nasty behaviours can rise if, for example, the time_zone param is passed with the next page requests and differs from the original one, or even between pages.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

@rjernst rjernst added the Team:QL (Deprecated) Meta label for query languages team label May 4, 2020
@bpintea bpintea mentioned this issue Apr 23, 2021
Closed
@wchaparro wchaparro removed the Team:QL (Deprecated) Meta label for query languages team label Jan 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@wchaparro
Copy link
Member

Superceded by ES|QL

@wchaparro wchaparro closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rjernst @matriv @wchaparro @elasticmachine @elasticsearchmachine