Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Create an annotation when a model snapshot is stored #52149

Closed
droberts195 opened this issue Feb 10, 2020 · 4 comments
Closed

[ML] Create an annotation when a model snapshot is stored #52149

droberts195 opened this issue Feb 10, 2020 · 4 comments
Labels
>enhancement :ml Machine learning

Comments

@droberts195
Copy link
Contributor

droberts195 commented Feb 10, 2020

Several users have indicated that they would find ML's model snapshot reversion functionality very useful if the visibility of this feature was better.

In a future release a model snapshot management page in the anomaly detection configuration section of the ML UI will help. However, we can also increase visibility that reverting to an old model snapshot is a possibility to make the model forget some period where it was fed invalid data by annotating the results views to record when model snapshots were created. If these annotations include the model snapshot ID then this will make it much clearer which model snapshot the administrator should revert to to make the model forget what it learnt during a period when the input to anomaly detection was undesirable in some way.

A precedent for the ML backend creating annotations exists in the form of our "delayed data" annotations.

A related piece of work is to delete these "snapshot created" annotations when the corresponding model snapshot is deleted by the nightly maintenance task after passing its expiry date, or when the entire job is deleted. (This may be more complex than it sounds as it creates a need to search for a specific annotation programmatically. If this requires considerable change then it can be implemented separately to the creation of the annotations.)

@droberts195 droberts195 added >enhancement :ml Machine learning labels Feb 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek self-assigned this Feb 18, 2020
@przemekwitek
Copy link
Contributor

Update: I'm starting work on this annotations-related task.

@przemekwitek
Copy link
Contributor

Here is how the annotation looks like in the UI:
image

@droberts195
Copy link
Contributor Author

Fixed by #53783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :ml Machine learning
Projects
None yet
Development

No branches or pull requests

3 participants