Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way for statements nodes to be internal in Painless #51836

Closed
jdconrad opened this issue Feb 3, 2020 · 2 comments
Closed

Add a way for statements nodes to be internal in Painless #51836

jdconrad opened this issue Feb 3, 2020 · 2 comments
Assignees
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team

Comments

@jdconrad
Copy link
Contributor

jdconrad commented Feb 3, 2020

All statement nodes in Painless contain a Location object that describes information about what generated the statement including a character offset and possibly a source code snippet. Currently, during ASM writing we check to ensure there are no statement offsets that collide with each other with an assert. We need a way to mark a statement as internal since we are going to decorate the ir tree with statements generated by code as opposed to a user. Collision detection can then ignore any internal statements.

Relates to: #49869

@jdconrad jdconrad added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring labels Feb 3, 2020
@jdconrad jdconrad self-assigned this Feb 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jdconrad jdconrad removed the needs:triage Requires assignment of a team area label label Dec 9, 2020
fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
fixmebot bot referenced this issue in VectorXz/elasticsearch May 28, 2021
fixmebot bot referenced this issue in VectorXz/elasticsearch Aug 4, 2021
@rjernst
Copy link
Member

rjernst commented May 25, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@rjernst rjernst closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants